Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request response client - create/destroy/lifecycle #355

Closed
wants to merge 7 commits into from

Conversation

bretambrose
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 76.56250% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 83.21%. Comparing base (419f5bc) to head (bd04ad5).

Files Patch % Lines
source/request-response/request_response_client.c 78.07% 25 Missing ⚠️
source/request-response/protocol_adapter.c 0.00% 2 Missing ⚠️
source/v5/mqtt5_to_mqtt3_adapter.c 0.00% 2 Missing ⚠️
source/request-response/subscription_manager.c 75.00% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           SubscriptionManager     #355      +/-   ##
=======================================================
+ Coverage                83.15%   83.21%   +0.05%     
=======================================================
  Files                       24       25       +1     
  Lines                     9493     9613     +120     
=======================================================
+ Hits                      7894     7999     +105     
- Misses                    1599     1614      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sbSteveK sbSteveK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid outside of potentially missing null checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants