-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request response client - create/destroy/lifecycle #355
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## SubscriptionManager #355 +/- ##
=======================================================
+ Coverage 83.15% 83.21% +0.05%
=======================================================
Files 24 25 +1
Lines 9493 9613 +120
=======================================================
+ Hits 7894 7999 +105
- Misses 1599 1614 +15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid outside of potentially missing null checks.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.