Underlying exception is sometimes swallowed in the logs

[changlinli]

I occasionally see the following log message.

EXCEPTION: RuntimeException: Exception thrown on sending thread: Exception while sending encoded chunk in MKV stream !

which ultimately comes from

amazon-kinesis-video-streams-producer-sdk-java/src/main/java/com/amazonaws/kinesisvideo/client/PutMediaClient.java

Line 138 in 026f890

throw new RuntimeException("Exception while sending encoded chunk in MKV stream ! ", e);

.

The previous line (

amazon-kinesis-video-streams-producer-sdk-java/src/main/java/com/amazonaws/kinesisvideo/client/PutMediaClient.java

Line 137 in 026f890

log.debug("Exception while sending data.", e);

) also logs the exception at a debug level, which results in

Exception while sending data.

Without the actual exception though, that debug message is fairly useless. The exception is in fact passed in as an argument to the log.debug statement, but it's never actually used, because log.debug expects a string template that looks something like "My message: %s"and no interpolation arguments are ever given in the log message.

Likewise nothing ever actually ends up printing the bottom level exception, because the top-level error handler (

amazon-kinesis-video-streams-producer-sdk-java/src/main/java/com/amazonaws/kinesisvideo/common/logging/Log.java

Line 289 in 026f890

public void exception(final Throwable e) {

) only ever prints the outer-most exception.

So the actual exception that caused all of this is effectively swallowed and never shown in the logs.

[MushMal]

Just a note that we are encouraging folks to submit PRs. Please feel free to open a PR. The normal process is to make modifications, create a new branch and push it in. The output will have a link to the PR which can be pushed for a review.