Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce M1 build in the CI #1108

Merged
merged 7 commits into from
Nov 29, 2023
Merged

Introduce M1 build in the CI #1108

merged 7 commits into from
Nov 29, 2023

Conversation

niyatim23
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@niyatim23 niyatim23 changed the title m1 build M1 build Nov 27, 2023
@niyatim23 niyatim23 changed the title M1 build Introduce M1 build in the CI Nov 28, 2023
@niyatim23 niyatim23 marked this pull request as ready for review November 28, 2023 19:29
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (24fdc52) 16.39% compared to head (6c9a1f5) 16.39%.

❗ Current head 6c9a1f5 differs from pull request most recent head 821d2d2. Consider uploading reports for the commit 821d2d2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1108   +/-   ##
========================================
  Coverage    16.39%   16.39%           
========================================
  Files           51       51           
  Lines         6849     6849           
========================================
  Hits          1123     1123           
  Misses        5726     5726           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niyatim23 niyatim23 requested a review from sirknightj November 29, 2023 17:05
sirknightj
sirknightj previously approved these changes Nov 29, 2023
stefankiesz
stefankiesz previously approved these changes Nov 29, 2023
@niyatim23 niyatim23 dismissed stale reviews from stefankiesz and sirknightj via 821d2d2 November 29, 2023 21:25
@stefankiesz
Copy link
Contributor

Nice, clang build doesn't take forever now 👍

@niyatim23 niyatim23 merged commit 8002fdf into develop Nov 29, 2023
15 checks passed
@niyatim23 niyatim23 deleted the m1-build branch November 29, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants