Handle aws special regions #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #430 +/- ##
===========================================
+ Coverage 64.17% 64.22% +0.04%
===========================================
Files 32 32
Lines 5075 5079 +4
===========================================
+ Hits 3257 3262 +5
+ Misses 1818 1817 -1 ☔ View full report in Codecov by Sentry. |
disa6302
reviewed
Jan 17, 2024
disa6302
approved these changes
Jan 17, 2024
sirknightj
reviewed
Jan 19, 2024
| @@ -79,12 +79,23 @@ STATUS createCurlApiCallbacks(PCallbacksProvider pCallbacksProvider, PCHAR regio | |||
|
|
|||
| // Set the control plane URL | |||
| if (controlPlaneUrl == NULL || controlPlaneUrl[0] == '\0') { | |||
There was a problem hiding this comment.
/nit We can use IS_NULL_OR_EMPTY_STRING macro
hassanctech
added a commit
that referenced
this pull request
Mar 11, 2024
* Added 1-20% jitter to expiration value stored by AwsCredentials struct. This is part of a larger effort to help customers with large fleets distribute the timings of their attempts to reconnect to our servers. * reduced clumped distribution between 1-2% * fix auth query template, used by signAwsRequestInfoQueryParam * aws service configurable for presigned urls, eg s3 * Update PIC to include modified threadpool teardown * use git tag commit from pic-develop * Update PIC to include modified threadpool teardown * use git tag commit from pic-develop * Set newly added timeouts to default value * Expose CONSTRAINED_DEVICE option * use develop tag * Add logging section (#417) * Introduce M1 build in the CI (#419) * m1 build * cmake update * run tests in m1 * Add setting of fragment meta to the sample * Formatting + style * More style * Small optimization * Update readme * Clang format * Clang format, again * Add gcc paths (#420) * spotaws PR #226 (#423) * proper versioned shared libs * Fix version * Update to latest version * Exclude shared builds from windows --------- Co-authored-by: Tom spot Callaway <spot@fedoraproject.org> Co-authored-by: Divya Sampath Kumar <disa6302@colorado.edu> Co-authored-by: Hassan Sahibzada <hsahibza@amazon.com> * Revert "Pr 323" * Added Iot credential usage to producer c samples (#220) * Added Iot credential usage to producer c samples * Refactor samples to include IoT usage and update readme --------- Co-authored-by: delaplan <delaplan@u48757f25b2c250.ant.amazon.com> Co-authored-by: Divya Sampath Kumar <disa6302@colorado.edu> * Update thing name length to be 128 as per AWS docs (#426) * Release build for producer C (#428) * Release build for producer C * Fix assert failure * Handle aws special regions (#430) * run windows tests with debug logging (#431) * run windows tests with debug logging * zero out frame buffer to avoid invalid mkv * fix tsan related issues (#427) fix tsan related issues * update pic hash to release candidate * add gcc m1 build * bump version for release * Add PR description lint (#438) * update pic to release tag --------- Co-authored-by: James Delaplane <delaplan@amazon.com> Co-authored-by: Michael Dietz <michael.dietz@waya.ai> Co-authored-by: Niyati Maheshwari <niyatim@amazon.com> Co-authored-by: Divya Sampath Kumar <disa6302@colorado.edu> Co-authored-by: Dave Johansen <davejohansen@gmail.com> Co-authored-by: Niyati Maheshwari <niyatim23@gmail.com> Co-authored-by: Jeremy Gunawan <jggunawa@amazon.com> Co-authored-by: Stefan Kieszkowski <85728496+stefankiesz@users.noreply.github.com> Co-authored-by: Tom spot Callaway <spot@fedoraproject.org> Co-authored-by: Jeremy Gunawan <sirknightj@gmail.com> Co-authored-by: delaplan <delaplan@u48757f25b2c250.ant.amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adding support for ADC and GovCloud regions (FIPS endpoints) + tests to confirm correct control plane url is created for the supplied region.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.