build: attempt setting tsc as clock source #2144
Merged
+26
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,15 +27,7 @@ function try-set-clocksource() { | |||
| fi | |||
| } | |||
|
|
|||
| case "$(imds /latest/meta-data/system)" in | |||
There was a problem hiding this comment.
I think we can remove this script and the associated systemd unit altogether. On AL2, we add an arg to the kernel cmdline that makes tsc the default (if it's available).
We do need to check AL2023, I'm not sure if tsc is baked-in as the default there.
There was a problem hiding this comment.
Ah ok, will look into this
|
Couldn't find docs on it but anecdotally it seems AL2023 also defaults to Xen as the clocksource for instances with a Xen hypervisor. I've moved the |
mselim00
force-pushed
the
correct-clocksource
branch
3 times, most recently
from
a522237 to
c72e3f2
Compare
mselim00
force-pushed
the
correct-clocksource
branch
from
c72e3f2 to
dfcbe65
Compare
|
/ci |
|
trying this again :) /ci |
|
/ci |
|
@ndbaker1 the workflow that you requested has completed. 🎉
|
|
/ci |
Issacwww
approved these changes
Feb 12, 2025
mselim00
changed the title
ndbaker1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Implements the recommendation by https://repost.aws/knowledge-center/manage-ec2-linux-clock-source to use
tscas the clocksource for all Intel/AMD instances.Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing Done
See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.
Tested on
t4g.small,m6i.large, andc4.largeinstances to confirm clocksource across the 3 different cases.t4g.smallis an arm64 instance and showed the clocksource asarch_sys_counterm6i.largeis nitro based and showed astsc.c4.largeis xen and showed astsc.