Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop pulling aws-iam-authenticator binary #1608

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

ndbaker1
Copy link
Member

@ndbaker1 ndbaker1 commented Jan 31, 2024

Issue #, if available:

Description of changes:

we are using aws eks get-token over aws-iam-authenticator since the aws cli version in AL2023 packages supports this feature generally.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Testing Done

testing nodegroup launch connects to cluster

See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.

@bryantbiggs
Copy link
Contributor

Does the kubelet kubeconfig need to be updated https://github.com/awslabs/amazon-eks-ami/blob/master/files/kubelet-kubeconfig

Or is nodeadm generating a different config with the awscli used instead?

@ndbaker1
Copy link
Member Author

is nodeadm generating a different config with the awscli used instead?

yep, there's an updated kubeconfig generated by nodeadm which doesn't rely on aws-iam-authenticator:
https://github.com/awslabs/amazon-eks-ami/blob/al2023/nodeadm/internal/kubelet/kubeconfig.template.yaml

Does the kubelet kubeconfig need to be updated https://github.com/awslabs/amazon-eks-ami/blob/master/files/kubelet-kubeconfig

this behavior is just for AL2023 using nodeadm, so the one for AL2 will still use the linked file

@cartermckinnon cartermckinnon merged commit a977128 into awslabs:al2023 Feb 1, 2024
9 checks passed
@ndbaker1 ndbaker1 deleted the remove-iam-auth-bin branch February 1, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants