Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary revert node name change #1600

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Temporary revert node name change #1600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nodeadm/internal/kubelet/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ func (ksc *kubeletConfig) withCloudProvider(cfg *api.NodeConfig, flags map[strin

// use ec2 instance-id as node hostname which is unique, stable, and incurs
// no additional requests
flags["hostname-override"] = cfg.Status.Instance.ID
// flags["hostname-override"] = cfg.Status.Instance.ID
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to override the hostname to the privateDnsName, or we'll run into the mess we did on AL2

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will the duration of the preview last for the related changes on instance-id names, or do we need to properly support this for X number of releases?

}

// When the DefaultReservedResources flag is enabled, override the kubelet
Expand Down
Loading