Temporary revert node name change #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -230,7 +230,7 @@ func (ksc *kubeletConfig) withCloudProvider(cfg *api.NodeConfig, flags map[strin | |||
|
|
|||
| // use ec2 instance-id as node hostname which is unique, stable, and incurs | |||
| // no additional requests | |||
| flags["hostname-override"] = cfg.Status.Instance.ID | |||
| // flags["hostname-override"] = cfg.Status.Instance.ID | |||
There was a problem hiding this comment.
We'll need to override the hostname to the privateDnsName, or we'll run into the mess we did on AL2
There was a problem hiding this comment.
will the duration of the preview last for the related changes on instance-id names, or do we need to properly support this for X number of releases?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
As discussed, revert this for tech preview release.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Testing Done
Build AMI: ami-0e01bf27ae252c408 and conformance tests passed
See this guide for recommended testing for PRs. Some tests may not apply. Completing tests and providing additional validation steps are not required, but it is recommended and may reduce review time and time to merge.