Skip to content

Commit a45686f

Browse files
committed
write default kubeletConfig to config path in drop-in dir versions
1 parent da91c80 commit a45686f

File tree

1 file changed

+17
-11
lines changed

1 file changed

+17
-11
lines changed

nodeadm/internal/kubelet/config.go

+17-11
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ type kubeletConfig struct {
6666
HairpinMode string `json:"hairpinMode"`
6767
ProtectKernelDefaults bool `json:"protectKernelDefaults"`
6868
ReadOnlyPort int `json:"readOnlyPort"`
69-
Logging logsapi.LoggingConfiguration `json:"logging"`
69+
Logging loggingConfiguration `json:"logging"`
7070
SerializeImagePulls bool `json:"serializeImagePulls"`
7171
ServerTLSBootstrap bool `json:"serverTLSBootstrap"`
7272
TLSCipherSuites []string `json:"tlsCipherSuites"`
@@ -79,6 +79,10 @@ type kubeletConfig struct {
7979
RegisterWithTaints []v1.Taint `json:"registerWithTaints,omitempty"`
8080
}
8181

82+
type loggingConfiguration struct {
83+
Verbosity logsapi.VerbosityLevel `json:"verbosity"`
84+
}
85+
8286
// Creates an internal kubelet configuration from the public facing bootstrap
8387
// kubelet configuration with additional sane defaults.
8488
func defaultKubeletSubConfig() kubeletConfig {
@@ -117,7 +121,7 @@ func defaultKubeletSubConfig() kubeletConfig {
117121
HairpinMode: "hairpin-veth",
118122
ProtectKernelDefaults: true,
119123
ReadOnlyPort: 0,
120-
Logging: logsapi.LoggingConfiguration{
124+
Logging: loggingConfiguration{
121125
Verbosity: 2,
122126
},
123127
SerializeImagePulls: false,
@@ -317,20 +321,22 @@ func (k *kubelet) writeKubeletConfigToDir(cfg *api.NodeConfig, userKubeletConfig
317321
return err
318322
}
319323

320-
dirPath := path.Join(kubeletConfigRoot, kubeletConfigDir)
321-
k.flags["config-dir"] = dirPath
322-
323-
zap.L().Info("Enabling kubelet config drop-in dir..")
324-
k.setEnv("KUBELET_CONFIG_DROPIN_DIR_ALPHA", "on")
324+
configPath := path.Join(kubeletConfigRoot, kubeletConfigFile)
325+
k.flags["config"] = configPath
325326

326-
filePath := path.Join(dirPath, "99-defaults.conf")
327-
zap.L().Info("Writing kubelet config to drop-in file..", zap.String("path", filePath))
328-
if err := util.WriteFileWithDir(filePath, kubeletConfigBytes, kubeletConfigPerm); err != nil {
327+
zap.L().Info("Writing kubelet config to file..", zap.String("path", configPath))
328+
if err := util.WriteFileWithDir(configPath, kubeletConfigBytes, kubeletConfigPerm); err != nil {
329329
return err
330330
}
331331

332332
if userKubeletConfig != nil && len(userKubeletConfig) > 0 {
333-
filePath = path.Join(dirPath, "00-overrides.conf")
333+
dirPath := path.Join(kubeletConfigRoot, kubeletConfigDir)
334+
k.flags["config-dir"] = dirPath
335+
336+
zap.L().Info("Enabling kubelet config drop-in dir..")
337+
k.setEnv("KUBELET_CONFIG_DROPIN_DIR_ALPHA", "on")
338+
339+
filePath := path.Join(dirPath, "00-overrides.conf")
334340
zap.L().Info("Writing user kubelet config to drop-in file..", zap.String("path", filePath))
335341
if err := util.WriteFileWithDir(filePath, userKubeletConfig, kubeletConfigPerm); err != nil {
336342
return err

0 commit comments

Comments
 (0)