Skip to content

python: Reformat python scripts using ruff #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Zhenye-Na
Copy link
Contributor

Issue #, if available:

Description of changes:

This PR includes the changes to only reformat the python scripts using ruff as declared in https://github.com/aws/aws-ofi-nccl/blob/master/contrib/python/pyproject.toml#L23 without changing any functionalities

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Nathan Na <nzhenye@amazon.com>
@Zhenye-Na Zhenye-Na marked this pull request as ready for review April 4, 2025 21:12
@Zhenye-Na Zhenye-Na requested a review from a team as a code owner April 4, 2025 21:12
Copy link
Contributor

@bwbarrett bwbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor

@yexiang-aws yexiang-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Nathan for cleaning up the format.

Earlier on, the feedback I got for a similar exercise is that it's not we are against format cleaning up, just that it comes with a downside of complicating the git blame (overrides the history of who actually added the core logic). And we recommend to clean up the format only along with whenever there's an actual business logic update to the code.

That's the north star we are(I'm personally) following right now, let me know if you have any questions.

@Zhenye-Na
Copy link
Contributor Author

Thank you Nathan for cleaning up the format.

Earlier on, the feedback I got for a similar exercise is that it's not we are against format cleaning up, just that it comes with a downside of complicating the git blame (overrides the history of who actually added the core logic). And we recommend to clean up the format only along with whenever there's an actual business logic update to the code.

That's the north star we are(I'm personally) following right now, let me know if you have any questions.

Cool - I am going to cancel this instead

@Zhenye-Na Zhenye-Na closed this Apr 9, 2025
@Zhenye-Na Zhenye-Na deleted the python_ruff_reformat branch April 9, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants