From 6981153c684dc06fb46f9b058d87ab6dac1deb10 Mon Sep 17 00:00:00 2001 From: Nicholas Sielicki Date: Wed, 11 Sep 2024 17:34:47 -0700 Subject: [PATCH] fix(platform-aws): fill all platform values commit ce214aa rearranged fields such that the written initializers were valid on most modern compilers, but it went unnoticed that this is insufficient for AL2's ancient toolchain, which fails with: > sorry, unimplemented: non-trivial designated initializers not supported provide all members for all entries to fix this. stack-info: PR: https://github.com/aws/aws-ofi-nccl/pull/595, branch: aws-nslick/stack/36 --- src/platform-aws.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/platform-aws.c b/src/platform-aws.c index 711bc6fe3..d573ad99b 100644 --- a/src/platform-aws.c +++ b/src/platform-aws.c @@ -34,7 +34,9 @@ struct ec2_platform_data { bool net_flush_required; const char *default_protocol; int domain_per_thread; -} platform_data_map[] = { +}; + +static struct ec2_platform_data platform_data_map[] = { { .name = "p4d.24xlarge", .topology = "p4d-24xl-topo.xml", @@ -88,6 +90,8 @@ struct ec2_platform_data { { .name = "g5.48xlarge", .topology = "g5.48xl-topo.xml", + .default_dup_conns = 0, + .latency = 75.0, .gdr_required = false, .net_flush_required = true, .default_protocol = "SENDRECV", @@ -95,6 +99,9 @@ struct ec2_platform_data { }, { .name = "trn1.32xlarge", + .topology = NULL, + .default_dup_conns = 0, + .latency = 75.0, .gdr_required = true, .net_flush_required = true, .default_protocol = "SENDRECV", @@ -102,6 +109,9 @@ struct ec2_platform_data { }, { .name = "trn1n.32xlarge", + .topology = NULL, + .default_dup_conns = 0, + .latency = 75.0, .gdr_required = true, .net_flush_required = true, .default_protocol = "SENDRECV",