fix(build): check features before mangling CFLAGS #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
aws-nslick/stack/31
branch
from
5beaf9d to
b22616e
Compare
This was referenced Sep 11, 2024
Merged
ghost
force-pushed
the
aws-nslick/stack/31
branch
from
b22616e to
7c86788
Compare
ghost
mentioned this pull request
ghost
force-pushed
the
aws-nslick/stack/31
branch
from
22cf81b to
78cc90c
Compare
ghost
force-pushed
the
aws-nslick/stack/31
branch
from
78cc90c to
189af46
Compare
ghost
mentioned this pull request
rauteric
previously approved these changes
Sep 13, 2024
ghost
force-pushed
the
aws-nslick/stack/31
branch
from
189af46 to
a4650f5
Compare
ghost
force-pushed
the
aws-nslick/stack/31
branch
from
a4650f5 to
201ec50
Compare
bwbarrett
previously requested changes
Sep 24, 2024
configure.ac
Outdated
| NCCL_OFI_PLATFORM="none" | ||
| AS_IF([test "${NCCL_OFI_PLATFORM}" = "none"], [AX_CHECK_PLATFORM_AWS()]) | ||
|
|
||
| AC_SUBST([NCCL_NET_OFI_DISTCHCK_CONFIGURE_FLAGS]) |
There was a problem hiding this comment.
This should not move up. The rest makes sense to me.
Yet another autotools fix: If any warning/devel CFLAGS would invoke warnings in headers used to detect dependencies, those dependencies will fail with a highly misleading/confusing error message: > configure: Found .git directory. Adding -Werror to CFLAGS. > checking if running on EC2 instance... yes > checking if want AWS platform optimizations... yes > checking for Libfabric 1.18.0 or later... no > configure: error: On AWS platforms, Libfabric 1.18.0 or later is required ie: it is not that Libfabric 1.18 was not found, it was that its headers produced warnings. Fix this by resolving all dependencies before modifying CFLAGS. Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
ghost
mentioned this pull request
ghost
force-pushed
the
aws-nslick/stack/29
branch
from
0dace6a to
e9b6309
Compare
ghost
force-pushed
the
aws-nslick/stack/31
branch
from
5504efb to
839fa16
Compare
|
bot:aws:retest |
bwbarrett
approved these changes
Sep 27, 2024
ghost
pushed a commit
that referenced
this pull request
Oct 1, 2024
Yet another autotools fix: If any warning/devel CFLAGS would invoke warnings in headers used to detect dependencies, those dependencies will fail with a highly misleading/confusing error message: > configure: Found .git directory. Adding -Werror to CFLAGS. > checking if running on EC2 instance... yes > checking if want AWS platform optimizations... yes > checking for Libfabric 1.18.0 or later... no > configure: error: On AWS platforms, Libfabric 1.18.0 or later is required ie: it is not that Libfabric 1.18 was not found, it was that its headers produced warnings. Fix this by resolving all dependencies before modifying CFLAGS. Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-ofiwg-bot
pushed a commit
to aws-ofiwg-bot/aws-ofi-nccl
that referenced
this pull request
Oct 4, 2024
Yet another autotools fix: If any warning/devel CFLAGS would invoke warnings in headers used to detect dependencies, those dependencies will fail with a highly misleading/confusing error message: > configure: Found .git directory. Adding -Werror to CFLAGS. > checking if running on EC2 instance... yes > checking if want AWS platform optimizations... yes > checking for Libfabric 1.18.0 or later... no > configure: error: On AWS platforms, Libfabric 1.18.0 or later is required ie: it is not that Libfabric 1.18 was not found, it was that its headers produced warnings. Fix this by resolving all dependencies before modifying CFLAGS. Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
fix(build): check features before mangling CFLAGS
Yet another autotools fix: If any warning/devel CFLAGS would invoke
warnings in headers used to detect dependencies, those dependencies will
fail with a highly misleading/confusing error message:
ie: it is not that Libfabric 1.18 was not found, it was that its headers
produced warnings. Fix this by resolving all dependencies before
modifying CFLAGS.