feat(build): add -Wextra to "picky" compiler flags #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
aws-nslick/stack/29
branch
from
487cce2 to
2108f5f
Compare
ghost
force-pushed
the
aws-nslick/stack/30
branch
from
ae9e42c to
8d39709
Compare
This was referenced Sep 11, 2024
Merged
ghost
force-pushed
the
aws-nslick/stack/30
branch
2 times, most recently
from
163c6bf to
a7cca1a
Compare
ghost
mentioned this pull request
ghost
force-pushed
the
aws-nslick/stack/30
branch
2 times, most recently
from
decf723 to
93a7011
Compare
This was referenced Sep 12, 2024
ghost
force-pushed
the
aws-nslick/stack/30
branch
from
93a7011 to
c51d55a
Compare
ghost
force-pushed
the
aws-nslick/stack/30
branch
from
c51d55a to
abbf61b
Compare
ghost
force-pushed
the
aws-nslick/stack/30
branch
from
abbf61b to
ec96367
Compare
rauteric
previously approved these changes
Sep 13, 2024
ghost
force-pushed
the
aws-nslick/stack/30
branch
from
ec96367 to
03c4994
Compare
Signed-off-by: Nicholas Sielicki <nslick@amazon.com> stack-info: PR: #588, branch: aws-nslick/stack/30
ghost
force-pushed
the
aws-nslick/stack/30
branch
from
03c4994 to
53ceba2
Compare
bwbarrett
approved these changes
Sep 24, 2024
ghost
mentioned this pull request
ghost
pushed a commit
that referenced
this pull request
Oct 1, 2024
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
aws-ofiwg-bot
pushed a commit
to aws-ofiwg-bot/aws-ofi-nccl
that referenced
this pull request
Oct 4, 2024
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
feat(build): add -Wextra to "picky" compiler flags
Signed-off-by: Nicholas Sielicki nslick@amazon.com