-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(.github/workflows): constrain push triggers to known branches #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5397f91
to
f9f2da4
Compare
This was referenced Sep 11, 2024
This was referenced Sep 11, 2024
Merged
f9f2da4
to
a73941b
Compare
This was referenced Sep 11, 2024
rauteric
approved these changes
Sep 11, 2024
Not sure what the goal here was... but this will still run CI on every PR (whether or not the base branch is known), right? |
a73941b
to
80f875a
Compare
Correct. |
pull_request triggers remain unchanged/unfiltered. stack-info: PR: #582, branch: aws-nslick/stack/26 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
80f875a
to
8cf469d
Compare
This was referenced Sep 12, 2024
aws-ofiwg-bot
pushed a commit
to aws-ofiwg-bot/aws-ofi-nccl
that referenced
this pull request
Oct 4, 2024
…ws#582) pull_request triggers remain unchanged/unfiltered. Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
-Wc++-compat' with
-x c++' #578chore(.github/workflows): constrain push triggers to known branches
pull_request triggers remain unchanged/unfiltered.
Signed-off-by: Nicholas Sielicki nslick@amazon.com