Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(param): move some parameters to unsigned #571

Closed
wants to merge 1 commit into from

Conversation

@ghost ghost self-requested a review as a code owner September 4, 2024 20:25
@ghost ghost force-pushed the aws-nslick/stack/17 branch from 7d8b9bc to c91092a Compare September 4, 2024 20:25
@ghost ghost force-pushed the aws-nslick/stack/18 branch from 787789e to 5fbcb38 Compare September 4, 2024 20:25
@ghost ghost changed the base branch from aws-nslick/stack/17 to master September 4, 2024 20:58
@ghost ghost requested review from rajachan, rauteric and bwbarrett as code owners September 4, 2024 20:58
@ghost ghost force-pushed the aws-nslick/stack/18 branch from 5fbcb38 to 293d619 Compare September 4, 2024 20:58
@ghost ghost changed the base branch from master to aws-nslick/stack/17 September 4, 2024 20:59
@ghost ghost changed the base branch from aws-nslick/stack/17 to master September 5, 2024 01:17
@ghost ghost changed the base branch from master to aws-nslick/stack/17 September 5, 2024 01:18
@ghost ghost changed the base branch from aws-nslick/stack/17 to master September 5, 2024 01:44
@ghost ghost force-pushed the aws-nslick/stack/18 branch from 293d619 to 960e6dd Compare September 5, 2024 01:44
@ghost ghost changed the base branch from master to aws-nslick/stack/17 September 5, 2024 01:45
@ghost ghost changed the base branch from aws-nslick/stack/17 to master September 5, 2024 01:56
@ghost ghost force-pushed the aws-nslick/stack/18 branch from 960e6dd to 3497c6d Compare September 5, 2024 01:56
@ghost ghost changed the base branch from master to aws-nslick/stack/17 September 5, 2024 01:56
@ghost ghost changed the base branch from aws-nslick/stack/17 to master September 5, 2024 02:03
@ghost ghost force-pushed the aws-nslick/stack/18 branch from 3497c6d to 005836f Compare September 5, 2024 02:03
@ghost ghost changed the base branch from master to aws-nslick/stack/17 September 5, 2024 02:03
@ghost ghost changed the base branch from aws-nslick/stack/17 to master September 5, 2024 02:08
@ghost ghost changed the base branch from master to aws-nslick/stack/17 September 11, 2024 23:13
@ghost ghost changed the base branch from aws-nslick/stack/17 to master September 12, 2024 00:17
@ghost ghost force-pushed the aws-nslick/stack/18 branch from e1b4367 to 578ed83 Compare September 12, 2024 00:17
@ghost ghost changed the base branch from master to aws-nslick/stack/17 September 12, 2024 00:18
@ghost ghost changed the base branch from aws-nslick/stack/17 to master September 12, 2024 00:56
@ghost ghost changed the base branch from master to aws-nslick/stack/17 September 12, 2024 00:57
@ghost ghost changed the base branch from aws-nslick/stack/17 to master September 12, 2024 01:09
@ghost ghost changed the base branch from master to aws-nslick/stack/17 September 12, 2024 01:10
@ghost ghost changed the base branch from aws-nslick/stack/17 to master September 12, 2024 01:51
@ghost ghost changed the base branch from master to aws-nslick/stack/17 September 12, 2024 01:52
@ghost ghost changed the base branch from aws-nslick/stack/17 to master September 13, 2024 17:48
@ghost ghost force-pushed the aws-nslick/stack/18 branch from 578ed83 to c7d1598 Compare September 13, 2024 17:49
@ghost ghost changed the base branch from master to aws-nslick/stack/17 September 13, 2024 17:50
@ghost ghost changed the base branch from aws-nslick/stack/17 to master September 14, 2024 22:36
@ghost ghost force-pushed the aws-nslick/stack/18 branch from c7d1598 to e4832c9 Compare September 14, 2024 22:37
@ghost ghost changed the base branch from master to aws-nslick/stack/17 September 14, 2024 22:37
mr_key_size and eager_max_size are positive integers, avoid sign
comparison issues by treating them as such.

stack-info: PR: #571, branch: aws-nslick/stack/18
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
@ghost ghost changed the base branch from aws-nslick/stack/17 to master September 17, 2024 20:25
@ghost ghost force-pushed the aws-nslick/stack/18 branch from e4832c9 to da89e97 Compare September 17, 2024 20:25
@ghost ghost changed the base branch from master to aws-nslick/stack/17 September 17, 2024 20:26
@bwbarrett
Copy link
Contributor

This really should have just been part of #570, but whatever.

@ghost
Copy link
Author

ghost commented Sep 26, 2024

Squashed this commit into #570. Thanks.

@ghost ghost closed this Sep 26, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant