-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(param): move some parameters to unsigned #571
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7d8b9bc
to
c91092a
Compare
787789e
to
5fbcb38
Compare
This was referenced Sep 4, 2024
Merged
5fbcb38
to
293d619
Compare
This was referenced Sep 4, 2024
293d619
to
960e6dd
Compare
960e6dd
to
3497c6d
Compare
3497c6d
to
005836f
Compare
e1b4367
to
578ed83
Compare
This was referenced Sep 12, 2024
This was referenced Sep 12, 2024
578ed83
to
c7d1598
Compare
c7d1598
to
e4832c9
Compare
mr_key_size and eager_max_size are positive integers, avoid sign comparison issues by treating them as such. stack-info: PR: #571, branch: aws-nslick/stack/18 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
e4832c9
to
da89e97
Compare
bwbarrett
approved these changes
Sep 24, 2024
This really should have just been part of #570, but whatever. |
Squashed this commit into #570. Thanks. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
fix(param): move some parameters to unsigned
mr_key_size and eager_max_size are positive integers, avoid sign
comparison issues by treating them as such.
Signed-off-by: Nicholas Sielicki nslick@amazon.com