fix(tree): move declarations to top of function

[ghost]

Stacked PRs:

• feat(test): parse as c++ source #568
• chore(build): mpi: set mpicxx, too. #567
• chore(build): add AC_PROG_CXX #566
• feat(rdma): constrain C linkage to init #591
• feat(build): add -Wextra to "picky" compiler flags #588
• fix(platform-aws): fill all platform values #595
• fix(tree): use empty brace initializers for zero-initialization #594
• fix(tracing/nvtx): silence -Wmissing-field-initializer warnings #593
• fix(build): check features before mangling CFLAGS #589
• fix(test): fix typing issues #587
• fix(neuron): remove const from ncclNetPlugin_v{4,5} syms #577
• fix(sendrecv): add missing nccl-headers include #576
• fix(rdma): avoid enum/integral comparison #586
• fix(tree): add fallthrough switch markers #585
• fix(rdma): use COMM_ID_MASK as invalid id #574
• fix(tree): avoid sign comparison issues #575
• fix(param): move some parameters to unsigned #571
• feat(param): add uint parameter macro #570
• fix(tuner): fix implicit conversions #573
• fix(tuner): avoid gotos #569
• fix(tree): use decltype instead of typeof for cxx #565
• ->fix(tree): move declarations to top of function #563

---

fix(tree): move declarations to top of function

c++ suppoorts initializers anywhere in the function, but one must not
jump over an initializer with any goto usage. Given the lack of RAII in
C, this becomes a significant painpoint.

In large to-be-eventually-refactored functions contain gotos or use
switch statements, split declaration and initialization, and move all
declarations to the top of the function. This makes switch statements
and gotos safe in both languages.
Signed-off-by: Nicholas Sielicki nslick@amazon.com

[ghost]

aws:bot:retest

[bwbarrett]

My old school C99 brain is happy now.

[ghost]

There was a bug on rebase:

diff --git a/src/nccl_ofi_net.c b/src/nccl_ofi_net.c
index 17e6ae2e..bcd27566 100644
--- a/src/nccl_ofi_net.c
+++ b/src/nccl_ofi_net.c
@@ -277,7 +277,7 @@ int nccl_net_ofi_create_plugin(nccl_net_ofi_plugin_t **plugin_p)
         * resources. This initialization happens once per process, and thus it
         * does not matter which device is used to create the endpoint.
         */
-       device = plugin->get_device(*plugin_p, 0);
+       device = plugin->get_device(plugin, 0);
 
        ret = device->get_ep(device, &base_ep);
        if (ret != 0) {

Prior to plugin_p being written to plugin a few lines down. Fixed.

[ghost]

bot:aws:retest