build: add [[maybe_unused]] on EXPORT macro #559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
aws-nslick/stack/6
branch
from
f150f7e to
66a5242
Compare
ghost
force-pushed
the
aws-nslick/stack/5
branch
from
58faa00 to
1906685
Compare
This was referenced Sep 4, 2024
bwbarrett
requested changes
Sep 4, 2024
| @@ -9,7 +9,11 @@ | |||
| #define OFI_LIKELY(x) __builtin_expect((x), 1) | |||
| #define OFI_UNLIKELY(x) __builtin_expect((x), 0) | |||
|
|
|||
| #ifdef __cplusplus | |||
| #define NCCL_OFI_EXPORT_SYMBOL __attribute__((visibility("default"))) [[maybe_unused]] | |||
There was a problem hiding this comment.
My comment from 19d4b38 remains; this shouldn't be necessary and I'd like to get to root cause before committing it.
ghost
force-pushed
the
aws-nslick/stack/6
branch
from
66a5242 to
b7da2b6
Compare
added 6 commits
September 4, 2024 12:14
the canonical token is __cplusplus not _cplusplus. When this is incorrect, linkage fails as cxx will perform name mangling when including these headers, resulting in a function with that mangle not existing. stack-info: PR: #554, branch: aws-nslick/stack/1 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
c++ requires literals not sit directly next to other literals and must be separated by at least one whitespace token. stack-info: PR: #555, branch: aws-nslick/stack/2 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
stack-info: PR: #556, branch: aws-nslick/stack/3 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
When using designated initializer lists, under C++ only, a warning will be emitted if the declaration order does not match the initialization order if any fields are missing in the initializer list. Reorder these structs to initialize all fields in their declaration order. stack-info: PR: #557, branch: aws-nslick/stack/4 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
void pointer arithmetic is illegal in c++; cast to uintptr, do the offset, then cast to void* to pass to libfabric. stack-info: PR: #558, branch: aws-nslick/stack/5 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
stack-info: PR: #559, branch: aws-nslick/stack/6 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
ghost
force-pushed
the
aws-nslick/stack/6
branch
from
b7da2b6 to
0d00bc2
Compare
ghost
force-pushed
the
aws-nslick/stack/5
branch
from
af00dd1 to
54488ee
Compare
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
build: add [[maybe_unused]] on EXPORT macro
Signed-off-by: Nicholas Sielicki nslick@amazon.com