fix(aws): align declaration and init order #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
aws-nslick/stack/3
branch
from
556e4e9 to
629605f
Compare
ghost
force-pushed
the
aws-nslick/stack/4
branch
from
179c91f to
348761d
Compare
This was referenced Sep 4, 2024
ghost
force-pushed
the
aws-nslick/stack/4
branch
from
348761d to
346b9d8
Compare
ghost
force-pushed
the
aws-nslick/stack/4
branch
from
346b9d8 to
0fae450
Compare
ghost
force-pushed
the
aws-nslick/stack/4
branch
from
0fae450 to
9ff12f4
Compare
ghost
changed the title
ghost
mentioned this pull request
Merged
rauteric
previously approved these changes
Sep 5, 2024
ghost
force-pushed
the
aws-nslick/stack/4
branch
from
9ff12f4 to
1abc4e2
Compare
ghost
mentioned this pull request
ghost
force-pushed
the
aws-nslick/stack/4
branch
from
1abc4e2 to
49ce3ec
Compare
ghost
force-pushed
the
aws-nslick/stack/4
branch
from
49ce3ec to
66c72b3
Compare
|
bot:aws:retest |
ghost
mentioned this pull request
When using designated initializer lists, under C++ only, a warning will be emitted if the declaration order does not match the initialization order if any fields are missing in the initializer list. Reorder these structs to initialize all fields in their declaration order. stack-info: PR: #557, branch: aws-nslick/stack/4 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
ghost
force-pushed
the
aws-nslick/stack/4
branch
from
66c72b3 to
fef7633
Compare
ghost
mentioned this pull request
rauteric
approved these changes
Sep 10, 2024
aws-ofiwg-bot
pushed a commit
to aws-ofiwg-bot/aws-ofi-nccl
that referenced
this pull request
Oct 4, 2024
When using designated initializer lists, under C++ only, a warning will be emitted if the declaration order does not match the initialization order if any fields are missing in the initializer list. Reorder these structs to initialize all fields in their declaration order. Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
-Wc++-compat' with-x c++' #578fix(aws): align declaration and init order
When using designated initializer lists, under C++ only, a warning will
be emitted if the declaration order does not match the initialization
order if any fields are missing in the initializer list. Reorder these
structs to initialize all fields in their declaration order.
Signed-off-by: Nicholas Sielicki nslick@amazon.com