Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tree): add spaces around PRIu64 #555

Merged
1 commit merged into from
Sep 8, 2024
Merged

fix(tree): add spaces around PRIu64 #555

1 commit merged into from
Sep 8, 2024

Conversation

@ghost ghost self-requested a review as a code owner September 4, 2024 16:44
@ghost ghost force-pushed the aws-nslick/stack/2 branch from f113230 to f57f3da Compare September 4, 2024 16:45
@ghost ghost changed the base branch from aws-nslick/stack/1 to master September 4, 2024 19:07
@ghost ghost requested review from rauteric and bwbarrett as code owners September 4, 2024 19:07
@ghost ghost force-pushed the aws-nslick/stack/2 branch from f57f3da to fa6c418 Compare September 4, 2024 19:07
@ghost ghost changed the base branch from master to aws-nslick/stack/1 September 4, 2024 19:07
@ghost ghost changed the base branch from aws-nslick/stack/1 to master September 4, 2024 19:16
@ghost ghost force-pushed the aws-nslick/stack/2 branch from fa6c418 to f2e1b4f Compare September 4, 2024 19:16
@ghost ghost changed the base branch from master to aws-nslick/stack/1 September 4, 2024 19:17
@ghost ghost changed the base branch from aws-nslick/stack/1 to master September 4, 2024 20:25
@ghost ghost force-pushed the aws-nslick/stack/2 branch from f2e1b4f to 92d7f02 Compare September 4, 2024 20:25
@ghost ghost changed the title tree: add spaces around PRIu64 fix(tree): add spaces around PRIu64 Sep 4, 2024
@ghost ghost changed the base branch from master to aws-nslick/stack/1 September 4, 2024 20:25
@ghost ghost changed the base branch from aws-nslick/stack/1 to master September 5, 2024 01:17
@ghost ghost changed the base branch from master to aws-nslick/stack/1 September 5, 2024 01:17
rauteric
rauteric previously approved these changes Sep 5, 2024
@ghost ghost changed the base branch from aws-nslick/stack/1 to master September 5, 2024 01:44
@ghost ghost dismissed rauteric’s stale review September 5, 2024 01:44

The base branch was changed.

@ghost ghost changed the base branch from master to aws-nslick/stack/1 September 5, 2024 01:44
@ghost ghost changed the base branch from aws-nslick/stack/1 to master September 5, 2024 01:55
@ghost ghost force-pushed the aws-nslick/stack/2 branch from 92d7f02 to cf92a28 Compare September 5, 2024 01:56
@ghost ghost changed the base branch from master to aws-nslick/stack/1 September 5, 2024 01:56
@ghost ghost changed the base branch from aws-nslick/stack/1 to master September 5, 2024 02:02
@ghost ghost changed the base branch from master to aws-nslick/stack/1 September 5, 2024 02:03
@ghost ghost changed the base branch from aws-nslick/stack/1 to master September 5, 2024 02:07
@ghost ghost changed the base branch from master to aws-nslick/stack/1 September 5, 2024 02:08
@ghost ghost changed the base branch from aws-nslick/stack/1 to master September 5, 2024 02:22
@a-szegel
Copy link
Contributor

a-szegel commented Sep 5, 2024

bot:aws:retest

rauteric
rauteric previously approved these changes Sep 5, 2024
@ghost ghost changed the base branch from master to aws-nslick/stack/1 September 6, 2024 20:10
ghost pushed a commit that referenced this pull request Sep 6, 2024
c++ requires literals not sit directly next to other literals and must
be separated by at least one whitespace token.

stack-info: PR: #555, branch: aws-nslick/stack/2
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
@ghost ghost force-pushed the aws-nslick/stack/2 branch from cf92a28 to 0a16b1f Compare September 6, 2024 20:19
@ghost ghost requested a review from a-szegel as a code owner September 6, 2024 20:19
c++ requires literals not sit directly next to other literals and must
be separated by at least one whitespace token.

stack-info: PR: #555, branch: aws-nslick/stack/2
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
@ghost ghost changed the base branch from aws-nslick/stack/1 to master September 6, 2024 20:31
@ghost ghost dismissed rauteric’s stale review September 6, 2024 20:31

The base branch was changed.

@ghost ghost force-pushed the aws-nslick/stack/2 branch from 0a16b1f to fda8f3a Compare September 6, 2024 20:32
@ghost
Copy link
Author

ghost commented Sep 8, 2024

bot:aws:retest

@ghost ghost merged commit b9bb318 into master Sep 8, 2024
62 of 63 checks passed
@ghost ghost deleted the aws-nslick/stack/2 branch September 27, 2024 00:55
aws-ofiwg-bot pushed a commit to aws-ofiwg-bot/aws-ofi-nccl that referenced this pull request Oct 4, 2024
c++ requires literals not sit directly next to other literals and must
be separated by at least one whitespace token.
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants