fix(tree): use correct __cplusplus guards #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
aws-nslick/stack/1
branch
from
b020a07 to
a4a1aa8
Compare
This was referenced Sep 4, 2024
rauteric
previously approved these changes
Sep 4, 2024
bwbarrett
previously requested changes
Sep 4, 2024
ghost
dismissed
bwbarrett’s stale review
Unrelated to commit contents, erroneously commented on code instead of pull request.
ghost
force-pushed
the
aws-nslick/stack/1
branch
from
a4a1aa8 to
fc862d7
Compare
ghost
force-pushed
the
aws-nslick/stack/1
branch
from
fc862d7 to
5a70a2f
Compare
the canonical token is __cplusplus not _cplusplus. When this is incorrect, linkage fails as cxx will perform name mangling when including these headers, resulting in a function with that mangle not existing. stack-info: PR: #554, branch: aws-nslick/stack/1 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
ghost
force-pushed
the
aws-nslick/stack/1
branch
from
5a70a2f to
cf0170a
Compare
ghost
changed the title
This was referenced Sep 4, 2024
Merged
This was referenced Sep 4, 2024
|
aws:bot:retest |
1 similar comment
|
aws:bot:retest |
rauteric
approved these changes
Sep 5, 2024
ghost
mentioned this pull request
|
bot:aws:retest |
1 similar comment
|
bot:aws:retest |
aws-ofiwg-bot
pushed a commit
to aws-ofiwg-bot/aws-ofi-nccl
that referenced
this pull request
Oct 4, 2024
the canonical token is __cplusplus not _cplusplus. When this is incorrect, linkage fails as cxx will perform name mangling when including these headers, resulting in a function with that mangle not existing. stack-info: PR: aws#554, branch: aws-nslick/stack/1 Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
-Wc++-compat' with-x c++' #578fix(tree): use correct __cplusplus guards
the canonical token is __cplusplus not _cplusplus. When this is
incorrect, linkage fails as cxx will perform name mangling when
including these headers, resulting in a function with that mangle not
existing.
Signed-off-by: Nicholas Sielicki nslick@amazon.com