Skip to content

Commit

Permalink
rdma: removed SAS ordering requirement
Browse files Browse the repository at this point in the history
There is no case in which not having Send-After-Send ordering causes issues,
so it is safe to remove it.
The only possible reordering that can happen is if a ctrl message is received
before a connect response message, but we already deal with this case correctly,
since the control message is added to the msgbuf and retrieved when isend is called.

Signed-off-by: Amedeo Sapio <asapio@amazon.com>
  • Loading branch information
AmedeoSapio committed Mar 27, 2024
1 parent 20dde1d commit a6ce048
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/nccl_ofi_rdma.c
Original file line number Diff line number Diff line change
Expand Up @@ -5743,8 +5743,8 @@ static void get_hints(struct fi_info *hints)

hints->mode = 0;

hints->tx_attr->msg_order = FI_ORDER_SAS;
hints->rx_attr->msg_order = FI_ORDER_SAS;
hints->tx_attr->msg_order = FI_ORDER_NONE;
hints->rx_attr->msg_order = FI_ORDER_NONE;

hints->ep_attr->type = FI_EP_RDM;

Expand Down

0 comments on commit a6ce048

Please sign in to comment.