Skip to content

Commit

Permalink
Add libpthread to library list
Browse files Browse the repository at this point in the history
Add libpthread to the library list, so it will be directly linked in
both the net plugin and executables.  The plugin uses pthreads, so
should have been including this by default.  We got lucky because
the pthread calls were in something we were building as a .so and
not in the unit tests.  But breaking that in a future commit breaks
the getting lucky part of the equation.

Signed-off-by: Brian Barrett <bbarrett@amazon.com>
  • Loading branch information
bwbarrett committed Apr 8, 2024
1 parent b00760e commit 53d1e90
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ AC_FUNC_MALLOC
AC_CHECK_FUNC([memset], [], [AC_MSG_ERROR([NCCL OFI Plugin requires memset function.])])
AC_CHECK_FUNC([realpath], [], [AC_MSG_ERROR([NCCL OFI Plugin requires realpath function.])])
AC_SEARCH_LIBS([dlopen], [dl], [], [AC_MSG_ERROR([NCCL OFI Plugin requires dlopen])])
AC_SEARCH_LIBS([pthread_getspecific], [pthread], [], [AC_MSG_ERROR([NCCL OFI Plugin requires pthreads.])])

# Check for GCC builtin functions
CHECK_GCC_BUILTIN([__builtin_expect])
Expand Down

0 comments on commit 53d1e90

Please sign in to comment.