From 53ceba28f1ce9f0878aae2323d05893b87535c38 Mon Sep 17 00:00:00 2001 From: Nicholas Sielicki Date: Wed, 11 Sep 2024 13:12:13 -0700 Subject: [PATCH] feat(build): add -Wextra to "picky" compiler flags Signed-off-by: Nicholas Sielicki stack-info: PR: https://github.com/aws/aws-ofi-nccl/pull/588, branch: aws-nslick/stack/30 --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 4340d4ce1..2e9e7ad03 100644 --- a/configure.ac +++ b/configure.ac @@ -143,14 +143,14 @@ AC_DEFINE_UNQUOTED([OFI_NCCL_TRACE], [${trace}], [Defined to 1 unit test output AC_ARG_ENABLE([picky-compiler], [AS_HELP_STRING([--disable-picky-compiler], [Disable adding picky compiler flags.])]) AS_IF([test "${enable_picky_compiler}" != "no"], - [picky_compiler_flags="-Wall -Wc++-compat" + [picky_compiler_flags="-Wall -Wc++-compat -Wextra -Wno-unused-parameter" AC_MSG_NOTICE([Adding ${picky_compiler_flags} to CFLAGS.]) CFLAGS="${CFLAGS} ${picky_compiler_flags}" AS_UNSET([picky_compiler_flags])]) AC_ARG_ENABLE([werror], [AS_HELP_STRING([--enable-werror], [Enable setting -Werror. Off by default, unless building from Git tree.])]) -werror_flags="-Werror" +werror_flags="-Werror -Wno-error=unused-parameter" AS_IF([test -d "${srcdir}/.git" -a -z "${enable_werror}"], [AC_MSG_NOTICE([Found .git directory. Adding ${werror_flags} to CFLAGS.]) CFLAGS="${CFLAGS} ${werror_flags}"],