Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot connect to SOCKS proxy #86

Closed
2 tasks done
AmeliaMcMullen opened this issue Jul 27, 2020 · 10 comments
Closed
2 tasks done

Cannot connect to SOCKS proxy #86

AmeliaMcMullen opened this issue Jul 27, 2020 · 10 comments
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue

Comments

@AmeliaMcMullen
Copy link

Confirm by changing [ ] to [x] below to ensure that it's a bug:

Known Issue

  • I'm using ATS data type endpoint: the endpoint should look like <prefix>-ats.iot.<region>.amazonaws.com

Describe the bug
A clear and concise description of what the bug is.
While using this new SDK I am able to connect to an HTTP proxy but when my proxy is SOCKS, it does not connect. I don't see a stack trace but it doesn't not connect and I don't see any communication through my proxy.
Is it expected that this SDK will support SOCKS proxy? Is there anything specific that has to be configured for SOCKS vs HTTP?

SDK version number
SDK: 1.2.4
CRT: 0.6.2

Platform/OS/Hardware/Device
What are you running the sdk on?
Samsung Galaxy S9
Android 8.0.0
Charles Proxy (free)

To Reproduce (observed behavior)
Steps to reproduce the behavior (please share code)
Attempt to run a sample application and connect to a SOCKS proxy.

Expected behavior
A clear and concise description of what you expected to happen.
Connect to the SOCKS proxy.

Logs/output
If applicable, add logs or error output.
No logs available.

@AmeliaMcMullen AmeliaMcMullen added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 27, 2020
@bretambrose
Copy link
Contributor

We do not have SOCKS support implemented yet. What kind of auth support would be sufficient for your use case? Basic (and no authentication at all) would be reasonably straightforward to implement, but GSSAPI would probably be a lot more work.

@bretambrose bretambrose added feature-request A feature should be added or improved. and removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 27, 2020
@AmeliaMcMullen
Copy link
Author

We don't have any authentication for the proxy.

@github-actions
Copy link

Greetings! Sorry to say but this is a very old issue that is probably not getting as much attention as it deservers. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one.

@github-actions github-actions bot added closing-soon This issue will automatically close in 5 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 5 days unless further comments are made. labels Jul 27, 2021
@jmklix jmklix reopened this Sep 22, 2021
@jmklix jmklix added the p3 This is a minor priority issue label Nov 7, 2022
@pbryniarski-logi
Copy link

Hi,
I'd like to ask what is the status of this issue?
Some of our customers are using SOCKS proxy (we are currently using sdk v1), we need to start supporting both HTTP and SOCKS proxy in our products but v2 SDK lacks SOCKS proxy.
Could you please prioritize this issue and ensure API parity so we can migrate from v1 to v2 SDK?
Thank you.

@bretambrose
Copy link
Contributor

bretambrose commented Apr 19, 2024

Socks support isn't on any roadmap or planning atm.

What kind of authentication support would you need?

Beyond that, all I can say is that versions prior to 5 will never be supported.

@pbryniarski-logi
Copy link

I don't think we need any auth at the moment. v1 sdk does not support proxy authentication as well

https://github.com/aws-amplify/aws-sdk-android/blob/8de48797ae2e5c157169a94746c768da7de61056/aws-android-sdk-iot/src/main/java/com/amazonaws/mobileconnectors/iot/AWSIotMqttManager.java#L841

SOCKS5 is ok.

@bretambrose
Copy link
Contributor

Understood.

One final thing, not trying to be pedantic, but clarity is important for setting expectations for feature parity and all: amplify's android sdk is a separate product that has no relation (externally or corporate-internal) with the IoT SDKs ; the v1 IoT SDK is here

@pbryniarski-logi
Copy link

One final thing, not trying to be pedantic, but clarity is important for setting expectations for feature parity and all: amplify's android sdk is a separate product that has no relation (externally or corporate-internal) with the IoT SDKs ; the v1 IoT SDK is here

Thank you for the clarification, tbh I'm bit confused on all those different SDK's and its versions.

@jmklix
Copy link
Member

jmklix commented May 17, 2024

Closing this as not planned due to resource constraints. If you still would like to use this sdk with SOCKS proxy please open a new feature request.

@jmklix jmklix closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2024
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

4 participants