-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-rds: possible regression with global endpoint address #33808
Comments
Using above code with Looks like in PR #33531, there was a schema change in L1 construct: ├[~] service aws-rds
│ └ resources
│ ├[~] resource AWS::RDS::DBInstance
│ │ └ properties
│ │ └[+] ApplyImmediately: boolean
│ ├[~] resource AWS::RDS::DBParameterGroup
│ │ └ properties
│ │ └ Parameters: (documentation changed)
│ └[~] resource AWS::RDS::GlobalCluster
│ ├ properties
│ │ └[-] GlobalEndpoint: GlobalEndpoint
│ └ attributes
│ └[+] GlobalEndpoint: GlobalEndpoint The Per AWS::RDS::GlobalCluster, there is no such property called |
@ashishdhingra is correct that this was due to a change on the CloudFormation side, in particular, the |
This change was confusing to us because |
Is this breaking change going to be documented anywhere? And when will the docs be updated to include attrGlobalEndpoint? |
@kellertk @jmklix I hear you and I have been following up on this. I have been searching for the team that made the change and brought to their attention that the CFN documentation for the As to the release notes, for the short term, we will call out L1 breaking changes as best as we can. Long term, we are finding ways to auto-catch the breaking changes that CloudFormation resources introduces. |
Hi, @samson-keung
Asking customers to reach out to paid support to prioritize a regression in open source software is a bit of an anti-pattern. One reason that CDK is open source is to customers can report issues and collaborate with the team without being having to pay for that privilege. Also, I'm an AWS employee, so AWS support would direct me to file an internal ticket with the CDK team (or CFN team) instead. If I did that, external customers couldn't benefit from the discussion here. |
This remains with the service team who made the breaking change, RDS team, to resolve internally and is not something we can resolve directly in CDK. Once they have updated the documentation, it will be reflected in CDK in the subsequent release of CDK. While CDK must respect upstream changes to CloudFormation, including breaking ones as the L1 constructs directly map to the CloudFormation resource, we acknowledge we can do a better job of communicating them when they occur in the release notes and are working on this. |
Describe the bug
There seems to have been a regression with
aws-rds
. TheglobalEndpoint
has been removed/changed with release v2.180.0.Regression Issue
Last Known Working CDK Version
v2.179.0
Expected Behavior
When trying to use the globalEndpoint you should be able to get the address of it.
Current Behavior
You currently get the following error on version 2.180.0 and above:
Reproduction Steps
run
cdk synth
on the following minimal project:Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.180.0
Framework Version
No response
Node.js Version
v22.13.1
OS
MacOS Sequoia 15.3.1
Language
TypeScript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: