Adding aws_sdk_2 trace prefix #1496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we have to change the usage in this template as well. |
|
Closing PR as opened another one- as the base PR in this one is terraform, however it should have been java-release/v1.31.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
ADOT Java Agent now prefixes like this for aws-sdk-2 scoped traces.
which is causing this failure.
springboot-otel-trace-metric-validation.yml is not used anywhere else other than for testing springboot app from java agent repo, which is using aws_sdk_2. Made changes accordingly.
Link to tracking Issue:
Testing:
Documentation:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.