Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Veirfy ADOT Image changed if applicable #678

Closed

Conversation

XinRanZhAWS
Copy link
Contributor

Description of changes:
If ADOT image have been updated via Patch, add a verification step to make sure the Image does updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@XinRanZhAWS XinRanZhAWS requested a review from a team as a code owner December 27, 2023 20:08
@majanjua-amzn majanjua-amzn self-requested a review January 9, 2024 17:16
@XinRanZhAWS XinRanZhAWS requested a review from harrryr January 9, 2024 17:48
Copy link
Contributor

@majanjua-amzn majanjua-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link test runs if you have run them. If not please run tests to prove it is functional

@XinRanZhAWS
Copy link
Contributor Author

@codecov-commenter
Copy link

Codecov Report

Attention: 102 lines in your changes are missing coverage. Please review.

Comparison is base (09e6487) 85.71% compared to head (1aa4117) 50.73%.
Report is 233 commits behind head on main.

Files Patch % Lines
...ent/providers/AwsAppSignalsCustomizerProvider.java 24.00% 35 Missing and 3 partials ⚠️
...gent/providers/AwsSpanMetricsProcessorBuilder.java 0.00% 20 Missing ⚠️
...ders/AttributePropagatingSpanProcessorBuilder.java 0.00% 16 Missing ⚠️
...viders/AwsMetricAttributesSpanExporterBuilder.java 0.00% 11 Missing ⚠️
...try/javaagent/providers/AwsSpanProcessingUtil.java 90.16% 1 Missing and 5 partials ⚠️
...vaagent/providers/AwsMetricAttributeGenerator.java 96.89% 2 Missing and 3 partials ⚠️
...y/javaagent/providers/AwsSpanMetricsProcessor.java 91.48% 0 Missing and 4 partials ⚠️
...t/providers/AttributePropagatingSpanProcessor.java 94.59% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##               main     #678       +/-   ##
=============================================
- Coverage     85.71%   50.73%   -34.99%     
- Complexity       19      264      +245     
=============================================
  Files             3       39       +36     
  Lines            49     1301     +1252     
  Branches          5      141      +136     
=============================================
+ Hits             42      660      +618     
- Misses            3      609      +606     
- Partials          4       32       +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@majanjua-amzn
Copy link
Contributor

Please run another test with a value given for the input appsignals-adot-image-name so we can see the behaviour when the ADOT image is changed.

Copy link

This PR is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the stale label Apr 14, 2024
@thpierce
Copy link
Contributor

This code is gone. Closing.

@thpierce thpierce closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants