[Bug fixes] Lambda - duplicate lambda spans + appsignals from unsampled spans #1000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 1 - Duplicate lambda root spans
The instrumentation produces 2 lambda root spans upon each invocation of the function. This is a known issue in OTel: open-telemetry/opentelemetry-java-instrumentation#7808
Fix
Issue 2 - Unsampled spans do not produce Application Signals metrics
On lambda environment, we export 100% of the spans to X-Ray to ensure we are able to provide 100% Application Signals metrics. However, currently only the sampled spans show up on the "Services" page and the unsampled spans do not.
Fix
aws.local.service
andaws.local.operation
which are required to generate Application Signals metrics.OtlpUdpSpanExporter
instance for unsampled spans with theAwsMetricAttributesSpanExporter
so that the exported spans have the desired attributes.Testing
OTEL_TRACES_SAMPLER
toalways_off
. Then I invoked the function once.Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.