Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Propagate mask correctly in allocated_fused_rms_norm_qkv kernel #48

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

aws-qieqingy
Copy link
Contributor

Issue #, if available:

N/A

Description of changes:

The mask of in the allocated_fused_rmsnorm_qkv kernel is not propagated correctly, and is causing failure in internal testing.

Testing:

Please see detailed unit test requirements in the CONTRIBUTING.md

  • The change is covered by numeric check using nki.baremetal
  • The change is covered by performance benchmark test using nki.benchmark
  • The change is covered by end-to-end integration test

Pull Request Checklist

  • I have filled in all the required field in the template
  • I have tested locally that all the tests pass
  • By submitting this pull request, I confirm that my contribution is made under the terms of the MIT-0 license.

Copy link

@aws-zhehongb aws-zhehongb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aws-zhehongb aws-zhehongb removed the request for review from ggumen February 5, 2025 06:25
@aws-zhehongb aws-zhehongb merged commit fc202b2 into aws-neuron:main Feb 5, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants