fix: Update messages when deploying a changeset when importing resources #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suppose we have a changeset that imports the resource (ex. a RDS DB instance).
```bash
$ ./rain ls rms-8-0-34 -c rms-8-0-34-changeset-v0
Arn: ***
Created: 2025-02-24 15:26:03.717 +0000 UTC
Description:
Status: AVAILABLE/CREATE_COMPLETE (Verify that resources and their properties defined in the template match the intended configuration of the resource import to avoid unexpected changes.)
Parameters: (None)
Changes:
Import [Replace]: RDSforMySQL (AWS::RDS::DBInstance) rms-8-0-40-created-by-cfn
```
When we try to execute a changeset using the rain deploy command, we get
the following “failed deploying stack” message.
```
$ rain deploy --changeset rms-8-0-34 rms-8-0-34-changeset-v0
Executing changeset 'rms-8-0-34-changeset-v0' as stack 'rms-8-0-34' in ap-northeast-1.
Stack rms-8-0-34: IMPORT_COMPLETE
failed deploying stack 'rms-8-0-34'
```
However, in the case of IMPORT_COMPLETE, the resource is in fact
successfully imported.
To avoid confusing users with this message, this PR modifies the message
displayed.
Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>
ericzbeard
approved these changes
Feb 24, 2025
haytok
deleted the
update_messages_in_deploy_changeset_for_import_resource
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose we have a changeset that imports the resource (ex. a RDS DB instance).
When we try to execute a changeset using the
rain deploycommand, we get the following failed deploying stack message.However, in the case of
IMPORT_COMPLETE, the resource is in fact successfully imported.To avoid confusing users with this message, this PR modifies the message displayed.
Issue #, if available: nothing
Description of changes: Details are above.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.