String type characters are converted to Boolean type characters

[yu40ta]

I am experiencing a phenomenon where source code that is recognized as "String" when deployed in the CloudFormation console is mistakenly converted to "Boolean" when deployed by rain.

For example, the following source code.

  EC2StopSchedule:
    Type: AWS::Scheduler::Schedule
    Properties:
      Name: ec2-auto-stop
      Description: "Scheduler to auto stop EC2 instances"
      ScheduleExpression: "cron(0 19 * * ? *)"
      ScheduleExpressionTimezone: Asia/Tokyo
      FlexibleTimeWindow:
        Mode: "OFF" # this
      State: ENABLED

Below I paste a capture of the execution result in console and in rain.

console

rain

Is this the expected behavior?
It appears that the double quotes have been removed for other properties except the FlexibleTimeWindow property too. (ex: Description property)
Unless this problem is resolved, templates that specify parameters with strings that can be Boolean will not be deployable.

[ericzbeard]

YAML doesn't require strings to be quoted. This might be related to #316, #319, and #329.

#329 added this:

To maintain original double quotes around values that require them, you can now add --node-style original to the deploy, pkg, and fmt commands.

[richard-grainger-veeva]

@ericzbeard The issue is more subtle. If stripping quotes from a string like "ON" transforms it into a YAML boolean, I don't think Rain should strip them, even if it would normally do so. Changing a data type is certainly unexpected behaviour I would suggest.

[leinardi]

@yu40ta this issue was fixed with #654