Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: has many record selection disables parent's actions #3636

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Feb 4, 2025

Description

Fixes #3575

Actions should only be enabled or disabled when a selected item belongs to the same context/resource. This way, in the "has many" context, only the relevant "has many" actions will be modified.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added the Fix label Feb 4, 2025
Copy link

codeclimate bot commented Feb 4, 2025

Code Climate has analyzed commit 5c063ad and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

@Paul-Bob Paul-Bob self-assigned this Feb 4, 2025
@Paul-Bob Paul-Bob merged commit aa56517 into main Feb 4, 2025
20 of 21 checks passed
@Paul-Bob Paul-Bob deleted the fix/action_select branch February 4, 2025 11:18
Copy link
Contributor

github-actions bot commented Feb 4, 2025

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Has many record selection disable parent's actions
1 participant