Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance Improvements for write and sum for SHA2 #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Performance Improvements for write and sum for SHA2 #2

wants to merge 2 commits into from

Conversation

skilesare
Copy link

@skilesare skilesare commented Jan 8, 2023 •
edited
Loading

Fixes #

Proposed Changes

  • I removed use of Array.tabulate from the SHA2 functions.
  • I have not done this for HAMC, but I'd suggest doing so.
  • I am now able to easily write 2MB x 12 writes in one cycle and as far as I can tell I can always calculate the hash even after adding 144 x 2MB blocks.

The tests are passing, but I have not yet tested the validity of a very large file.

See: https://m7sm4-2iaaa-aaaab-qabra-cai.raw.ic0.app/?tag=637638194 and https://forum.dfinity.org/t/progressive-sha256/17853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skilesare