-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: split rustywind
into multiple crates so that it can also be made available as a library
#100
Conversation
Hey @Rolv-Apneseth sorry I didn’t see this till now. I won’t be able to review till Tuesday.
Is this ready to review now? Or does it need to be in draft longer? |
Sure, no rush at all. Sorry, wanted to ask those questions first, it can be ready for review yeah. Just need to change the versions and look into that workflow failing |
Not sure what the issue was with that workflow failing, globbing was broken somehow? I could maybe change it to just run |
Ya let’s change it to that |
Cool I'll change it. Is this comment still relevant?
Edit: Also actions-rs/toolchain has been archived. Could I try change it to something like this, like I have here: jobs:
rustfmt:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Install stable toolchain
run: rustup toolchain install stable
- name: Format
run: cargo fmt --check -- --edition 2021 |
Oh, or this one from dtolnay if you prefer |
No that can be removed |
Alright done. Any thoughts about changing the action or leave it as is? |
looks good @Rolv-Apneseth thanks! I'll merge it in today. |
Nice, thank you |
Added some docs: https://docs.rs/rustywind_core/latest/rustywind_core/ |
In relation to #95
Continuing on from bram209's branch, so most of the credit goes to him.
Opening this PR now because I need some pointers:
That latest commit I pushed, was just replacing the default
WriteMode::DryRun
withWriteMode::ToConsole
becauseclippy
is complaining thatToConsole
is never constructed, andDryRun
already has an option dedicated to it. If this is wrong, would you mind clarifying what the purpose ofToConsole
is, and how I should fix that linting error?For adding a workflow to publish
rustywind_core
, would that just be something like this (found on the internet):or should it be using an action like this?
For
rustywind_vite
, what should the description be? And is this also to be published as a separate library?Should versioning be different for all 3 crates?
How can I check CI/CD workflows are working? I have ensured
clippy
andrustfmt
are happy locally.Did I miss anything else?