Reduce NativeTokenHome's receive method gas cost #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cam-schultz
requested review from
iansuvak,
richardpringle,
geoff-vball,
bernard-avalabs,
michaelkaplan13 and
mdelle1
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+123
to
+126
| require( | ||
| msg.sender == address(_getNativeTokenHomeStorage()._wrappedToken), | ||
| "NativeTokenHome: invalid receive payable sender" | ||
| ); |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: solidity.performance.use-custom-error-not-require.use-custom-error-not-require Note
Comment on lines
+123
to
+126
| require( | ||
| msg.sender == address(_getNativeTokenHomeStorage()._wrappedToken), | ||
| "NativeTokenHome: invalid receive payable sender" | ||
| ); |
Check notice
Code scanning / Semgrep OSS
Semgrep Finding: solidity.performance.use-short-revert-string.use-short-revert-string Note
cam-schultz
changed the title
geoff-vball
approved these changes
Feb 18, 2025
iansuvak
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fixes #722
How this works
Rather than call the public method
getTokenAddress, which results in an external call, we can fetch the same address directly fromNativeTokenHome's state.How this was tested
Manual testing with unoptimized contract builds. To reproduce:
optimizer = falseto the default profile infoundry.tomlforge test --match-test testReceiveWithdrawSuccess --match-contract NativeTokenHomeTest -vvvv --gas-reportreceivemethod in the trace (263versus2311before this change)To observe the test failing as a result of disabling optimization (and without this change, of course), replace
sendValuewithtransferin the test wrapped token contract.Automated testing
Automated tests would require a separate test profile that disables optimization. I consider that out of scope for this issue.
How is this documented
N/A