Update proposervm summary to roll forward only #3950
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronbuchwald
commented
May 8, 2025
Comment on lines
+56
to
+59
| innerVM.GetBlockF = func(_ context.Context, blkID ids.ID) (snowman.Block, error) { | ||
| if blkID != snowmantest.Genesis.ID() { | ||
| return nil, database.ErrNotFound | ||
| } |
There was a problem hiding this comment.
Ensure that the default test setup does not silently ignore the blkID parameter and return the genesis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR fixes #3948 caused by #3831 violating an invariant that the ProposerVM index must always be >= the innerVM index.
How this works
Rather than the proposerVM always accepting the state sync summary, this PR ensures the ProposerVM index only moves forward. This means that if the accepted state sync summary is below the proposerVM's last accepted height, it allows the ProposerVM and InnerVM to diverge.
This will be corrected when state sync finishes and
SetStateis called and the ProposerVM re-aligns the two. Since we keep the ProposerVM roll forward only, we are still able to roll it back and guarantee that they are re-aligned before we entre consensus.How this was tested
Existing unit tests
Need to be documented in RELEASES.md?
No