refactor genesis building logic in avm and platformvm #3949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DracoLi
commented
May 8, 2025
| "Jz9ayEDt7dx9hDx45aXALujWmL9ZUuqe7", | ||
| } | ||
|
|
||
| func TestBuildGenesis(t *testing.T) { |
There was a problem hiding this comment.
Added back this test, which was removed in #2589. I think its worth keeping for testing the BuildGenesis function, but please let me know if this should just be removed or needs adjustments.
DracoLi
force-pushed
the
dl/remove-static-service
branch
from
90ec163 to
9d9fbcd
Compare
joshua-kim
reviewed
May 8, 2025
vms/avm/genesis_builder.go
Outdated
| @@ -88,7 +80,7 @@ type BuildGenesisReply struct { | |||
|
|
|||
| // BuildGenesis returns the UTXOs such that at least one address in [args.Addresses] is | |||
| // referenced in the UTXO. | |||
| func (*StaticService) BuildGenesis(_ *http.Request, args *BuildGenesisArgs, reply *BuildGenesisReply) error { | |||
| func BuildGenesis(args *BuildGenesisArgs, reply *BuildGenesisReply) error { | |||
There was a problem hiding this comment.
Can we also get rid of all these args/reply structs and just make them parameters/return values/structs?
There was a problem hiding this comment.
yep good point, i'll update this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Resolves #2613, we no longer need static structs to create genesis.
How this works
StaticServicefrom bothplaftformvmandavmBuildGenesisHow this was tested
unit test