Prefix PoP methods and message with Sign

ava-labs · Feb 6, 2025 · 1ccd0ce · 1ccd0ce
1 parent 3990460
commit 1ccd0ce
Show file tree

Hide file tree

Showing 5 changed files with 33 additions and 32 deletions.
diff --git a/proto/pb/signer/signer.pb.go b/proto/pb/signer/signer.pb.go
diff --git a/proto/pb/signer/signer_grpc.pb.go b/proto/pb/signer/signer_grpc.pb.go
diff --git a/proto/signer/signer.proto b/proto/signer/signer.proto
@@ -7,7 +7,7 @@ option go_package = "github.com/ava-labs/avalanchego/proto/pb/signer";
 service Signer {
   rpc PublicKey(PublicKeyRequest) returns (PublicKeyResponse) {}
   rpc Sign(SignatureRequest) returns (SignatureResponse) {}
-  rpc ProofOfPossession(ProofOfPossessionSignatureRequest) returns (ProofOfPossessionSignatureResponse) {}
+  rpc SignProofOfPossession(ProofOfPossessionSignatureRequest) returns (ProofOfPossessionSignatureResponse) {}
 }
 
 message PublicKeyRequest {}

diff --git a/utils/crypto/bls/signer/rpcsigner/client.go b/utils/crypto/bls/signer/rpcsigner/client.go
@@ -78,7 +78,7 @@ func (c *Client) Sign(message []byte) (*bls.Signature, error) {
 }
 
 func (c *Client) SignProofOfPossession(message []byte) (*bls.Signature, error) {
-	resp, err := c.client.ProofOfPossession(context.Background(), &pb.ProofOfPossessionSignatureRequest{Message: message})
+	resp, err := c.client.SignProofOfPossession(context.Background(), &pb.ProofOfPossessionSignatureRequest{Message: message})
 	if err != nil {
 		return nil, err
 	}

diff --git a/utils/crypto/bls/signer/rpcsigner/server_test.go b/utils/crypto/bls/signer/rpcsigner/server_test.go
@@ -47,7 +47,7 @@ func (s *server) Sign(_ context.Context, in *signer.SignatureRequest) (*signer.S
 	}, nil
 }
 
-func (s *server) ProofOfPossession(_ context.Context, in *signer.ProofOfPossessionSignatureRequest) (*signer.ProofOfPossessionSignatureResponse, error) {
+func (s *server) SignProofOfPossession(_ context.Context, in *signer.ProofOfPossessionSignatureRequest) (*signer.ProofOfPossessionSignatureResponse, error) {
 	signature, err := s.localSigner.SignProofOfPossession(in.Message)
 	if err != nil {
 		return nil, err