Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yaw control launch file #79

Merged
merged 1 commit into from
Aug 22, 2016

Conversation

icyflame
Copy link
Member

@icyflame icyflame commented Oct 2, 2015

  • These files have not been tested on the vehicle yet.
  • They can be merged once they have been tested on the vehicle.

cc @auviitkgp/developers @auviitkgp/embedded-team

@icyflame
Copy link
Member Author

icyflame commented Nov 1, 2015

Two of the launch files were tested on the vehicle on 31/10/2015 with @aniket11bh and @kalyan-kumar .

Both imuDvl.launch and poseEstimator.launch are working. Only change to be made, is to chmod +x the sparton.py file to make it executable. These two vehicle launch files will be merged in another PR.

TODO: Check yawControl.launch file.

cc @prudhvid @kshitijgoel007

@prudhvid
Copy link
Contributor

prudhvid commented Nov 1, 2015

@icyflame how good is poseEstimator ? Is it giving correct values? Did you test that?

@icyflame
Copy link
Member Author

icyflame commented Nov 1, 2015

@prudhvid As a matter of fact, Pose Estimator has been working since summer itself. (pose_server_python, merged in #56 ) and it works well, we checked that it gives correct values as per the quadrants, and the relative values are fine.

We haven't been able to test the absolute correctness of the values though.

Say, we move the vehicle by sqrt(2) meters at 45 degrees in the first quadrant, we have checked that both the coordinates are +ve, although we were unable to check if the coordinates were exactly (1, 1). Same for all 4 quadrants.

@aniket11bh has some planned enhancements, (see #77 ) that will make it more accurate, though we need to figure out how to test the absolute values for pose-estimator.

icyflame added a commit to icyflame/kraken_3.0 that referenced this pull request Nov 4, 2015
- explained  testing in

  auviitkgp#79 (comment)

Signed-off-by: Siddharth Kannan <kannan.siddharth12@gmail.com>
Signed-off-by: Siddharth Kannan <kannan.siddharth12@gmail.com>
@icyflame icyflame force-pushed the add-vehicle-launch-files branch from 5cc379d to cb18b3f Compare November 12, 2015 16:44
@icyflame
Copy link
Member Author

yawControl.launch file could not be tested because the required packages were not installed on the vehicle.

@icyflame icyflame changed the title [WIP] Add the vehicle launch files Add yaw control launch file Aug 22, 2016
@icyflame icyflame merged commit e754e71 into auviitkgp:indigo-devel Aug 22, 2016
@kshitijgoel007
Copy link

Is the yawControl.launch now tested? Let's close this.

@icyflame
Copy link
Member Author

icyflame commented Sep 2, 2016

@kshitijgoel007 This has been closed 11 days ago 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants