Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing remap to make sure IMU and DVL data is extracted properly #76

Merged

Conversation

icyflame
Copy link
Member

@icyflame icyflame commented Oct 1, 2015

  • Data from the simulator is in the messages sensor_msgs/Imu and underwater_sensor_msgs/DVL
  • Me and @aniket11bh have converted this message into the kraken_msgs/imuData and kraken_msgs/dvlData message formats.
  • And then published these formats on the IMU and DVL topics.

FIXES #74
FIXES #75

TODO:

We have already tested this code, and the pose_server_python is working as we want it too. So, I will be merging this within an hour or two. I am opening this PR for posterity.

cc @prudhvid @kalyan-kumar @kshitijgoel007

- The message type is converted from sensor_msgs/Imu to
  kraken_msgs/imuData.

Signed-off-by: Siddharth Kannan <kannan.siddharth12@gmail.com>
Signed-off-by: Siddharth Kannan <kannan.siddharth12@gmail.com>
Signed-off-by: Siddharth Kannan <kannan.siddharth12@gmail.com>
Signed-off-by: Siddharth Kannan <kannan.siddharth12@gmail.com>
@prudhvid
Copy link
Contributor

prudhvid commented Oct 1, 2015

@icyflame
Copy link
Member Author

icyflame commented Oct 1, 2015

@prudhvid Yeah, I think they are the same. But we have used an external package for the Quaternion to Euler conversion, and we have integrated it into remap.py itself, so, there was no requirement to change the remap.launch file. So, I think we can have this in the repo as well.

@prudhvid
Copy link
Contributor

prudhvid commented Oct 1, 2015

Okay.

On Fri, Oct 2, 2015 at 3:13 AM, Siddharth Kannan notifications@github.com
wrote:

@prudhvid https://github.com/prudhvid Yeah, I think they are the same.
But we have used an external package for the Quaternion to Euler
conversion, and we have integrated it into remap.py itself, so, there was
no requirement to change the remap.launch file. So, I think we can have
this in the repo as well.


Reply to this email directly or view it on GitHub
#76 (comment).

Prudhvi Dharmana

B.Tech 4th year
Dept. of Computer Science & Engineering
IIT Kharagpur.

- Now, thruster_force_converter is not required anymore.
- The data published by control.py Node is directly subscribed to, by
  the remap node and then, remap publishes that to g500 's thruster
  input topic.

Signed-off-by: Siddharth Kannan <kannan.siddharth12@gmail.com>
icyflame added a commit that referenced this pull request Oct 1, 2015
- Add missing remap to make sure IMU and DVL data is extracted properly.
  - By converting the message types used by g500 to message types used by kraken_3.0 packages.
- Remap the thruster data sent by control nodes directly.
- Remove the necessity of running a `thruster_force_converter` node.
- Code has been tested with the yawControl node, and the architecture is setup properly. Problems in `control.py` hamper testing.
- Code has been tested with `pose_server_python`, it works!

FIXES #74 
FIXES #75
@icyflame icyflame merged commit d0cd76d into auviitkgp:indigo-devel Oct 1, 2015
@icyflame icyflame deleted the convert-imu-data-from-simulator branch October 1, 2015 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants