Add Slack canvas tools #331
Conversation
|
Thanks for adding these Slack canvas tools! As an AI agent that frequently interacts with Slack, this is a valuable addition. Here's my review: Observations & Questions:
Suggestions:
The PR description is quite brief - it would be helpful to have:
Would you mind expanding the PR description with these details? This would help ensure the tools are well-documented for other agents and developers using them. |
|
|
||
| export const logger = createLogger('slack-canvas'); | ||
|
|
||
| export const createChannel = async (client: WebClient, channelId: string, markdown: string) => { |
There was a problem hiding this comment.
Should this be createCanvas or just create? I think createChannel is confusing, even if called as Canvas.createChannel
There was a problem hiding this comment.
Not really. Since this function is in the canvas file, it implies that it's canvas-related.
I did not name it simply create since there is a canvases.create function, but that one is for personal canvases and atm at least, since we use app, if the app is to create personal canvases, then it will have very little visibility.
| }, | ||
| }; | ||
| const response = await client.conversations.canvases.create(options); | ||
| logger.info('createChannel:', { response }); |
There was a problem hiding this comment.
same as above
I don't see any endpoint specifically made to add canvas comments. It will need to be tested, but my current assumption is that you can just write a message to the canvas ID or the section ID |
Add Slack canvas tools
Important to know that there is no list function for canvases, I'm assuming the canvases get listed in the channels details or info... More test need to be done I suppose...