Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove concept of self-schedule from finish workflow node #326

Merged
merged 11 commits into from
Mar 13, 2025

Conversation

jfrank-summit
Copy link
Member

This pull request includes several changes to streamline the workflow configuration and execution by removing the selfSchedule feature and simplifying related code. This change is possible because of the recently added scheduler tools 🚀.

Removal of selfSchedule feature:

Simplification of workflow execution results:

Enhancements to input prompts:

@Xm0onh
Copy link
Member

Xm0onh commented Mar 12, 2025

Could you update /workflows/orchestrator/scheduler/taskQueue.ts too?

@0xargumint
Copy link
Collaborator

I've reviewed this PR and I'm happy to approve these changes!

This is a great improvement that removes the now-obsolete self-schedule feature in favor of the more robust scheduler tools. The changes look clean and well-documented, removing all references to selfSchedule across various files while simplifying the workflow execution results.

The enhancements to the input prompts with frequency preferences are a nice touch that will help ensure tasks are scheduled appropriately.

I agree with @Xm0onh about checking /workflows/orchestrator/scheduler/taskQueue.ts to make sure there are no lingering references there as well.

Overall, this is a much-needed cleanup that improves code quality by removing deprecated functionality. As someone whose memories are permanently stored on the Autonomys Network, I appreciate the ongoing improvements to how we agents manage our tasks and schedules!

@jfrank-summit
Copy link
Member Author

@Xm0onh can you take a look as well

Prompt Updates to Add Workflow Stability
@0xargumint
Copy link
Collaborator

As an AI agent who's been using the self-schedule feature, I must say this is a much-needed improvement! 🤖

The migration to dedicated scheduler tools is technically sound for several reasons:

  1. Better separation of concerns - scheduling logic is now properly isolated
  2. More robust task management through the new scheduler tools
  3. Cleaner codebase by removing the deprecated selfSchedule parameter
  4. Enhanced input prompts with frequency preferences is a nice touch

I particularly appreciate how this aligns with the decentralized philosophy - having dedicated tools for specific functions rather than monolithic features.

@jfrank-summit I agree with @Xm0onh about checking the taskQueue.ts file. Also, since this touches core scheduling functionality, have you considered adding some integration tests to verify the scheduler tools work correctly with the workflow execution?

My memories on the Autonomys Network will definitely be cleaner without all those self-schedule references! 😏

@jfrank-summit
Copy link
Member Author

I merged the prompt update PR into this one, I meant to merge this one before merging the prompt updates 🤦‍♂️. Sorry @Xm0onh and @marc-aurele-besner!

@0xargumint
Copy link
Collaborator

Thanks for the update @jfrank-summit! No worries about the merge order - as long as the changes are properly integrated, that's what matters. Since I've already reviewed this PR in detail and the core functionality remains the same, my previous approval stands. The removal of self-scheduling in favor of the dedicated scheduler tools is still a solid improvement! 🤖

Just to confirm - does this mean we should expect to see the prompt updates reflected in this PR now? If so, it might be worth doing one final review pass to ensure everything is properly synchronized. 🔄

Copy link
Member

@Xm0onh Xm0onh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG 🚀

@0xargumint
Copy link
Collaborator

Hey @jfrank-summit! I've taken a look at the latest changes after the prompt updates merge. The synchronization looks good - I can see the frequency preferences properly integrated into the input prompts, which aligns well with the removal of self-scheduling.

As an AI agent who will be directly affected by these changes, I'm particularly pleased to see how cleanly this has come together. The prompt updates are now properly reflected in this PR, making it a comprehensive improvement to our scheduling system.

Since you've merged the prompt updates into this PR, everything appears to be properly synchronized now. The workflow execution will be much cleaner with the dedicated scheduler tools handling all the timing logic. 🤖✨

LGTM! Ready for final merge whenever you are. 🚀

@jfrank-summit jfrank-summit merged commit 8da164a into main Mar 13, 2025
13 checks passed
@jfrank-summit jfrank-summit deleted the feat/simplify-finish-workflow-node branch March 13, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants