Improve encoding management #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for auto-drive-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
marc-aurele-besner
previously approved these changes
Mar 5, 2025
clostao
dismissed
marc-aurele-besner’s stale review
The merge-base changed after approval.
marc-aurele-besner
previously approved these changes
Mar 5, 2025
clostao
dismissed
marc-aurele-besner’s stale review
The merge-base changed after approval.
marc-aurele-besner
previously approved these changes
Mar 5, 2025
clostao
dismissed
marc-aurele-besner’s stale review
The merge-base changed after approval.
marc-aurele-besner
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encoding management of downloaded files has been a bit of an issue since we were conditionally encoding depending on user request headers.
I'm implementing a set of PRs within Auto-Drive repo's for improve the way we handle this complexity. For prior versions of our SDK we don't have a better approach than relying on headers though for newer versions this won't be an issue anymore.