Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: rename workflows and replace stalebot #67

Merged
merged 3 commits into from
Nov 25, 2020

Conversation

dmccaffery
Copy link
Member

@dmccaffery dmccaffery commented Nov 24, 2020

  • rename workflows to normalise with most open-source projects
  • replace stalebot configuration with stale workflow
    • achieves the same result without requiring a third-party integration
  • introduce next branch
    • acts as a prerelease branch
    • now the default target for pull requests
    • required to support development for apple silicon, which may take a
      few iterations to get right
    • allows multiple features / fixes to be batched into a prompt release
  • cleanup readme
    • correctly identify validated operating systems
    • replace badges for github worflows and next branch

fix(switch-smart-card): ignore missing keygrips

Closes: #68
Related: #66

* rename workflows to normalise with most open-source projects
* replace stalebot configuration with stale workflow
  - achieves the same result without requiring a third-party integration
* introduce next branch
  - acts as a prerelease branch
  - now the default target for pull requests
  - required to support development for apple silicon, which may take a
    few iterations to get right
  - allows multiple features / fixes to be batched into a prompt release
* cleanup readme
  - correctly identify validated operating systems
  - replace badges for github worflows and next branch
@dmccaffery
Copy link
Member Author

@sjk07 -- a webhook with circleci caused the status check to still appear despite the build being removed. I fixed it after seeing it in this PR -- it should not appear again.

Copy link
Contributor

@patrickserrano patrickserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@dmccaffery
Copy link
Member Author

LTGM

Can you approve it? :-D

@patrickserrano
Copy link
Contributor

LTGM

Can you approve it? :-D

I did! lol

I think @sjk07 needs to, he's marked as a code owner.

@dmccaffery
Copy link
Member Author

LTGM

Can you approve it? :-D

I did! lol

I think @sjk07 needs to, he's marked as a code owner.

Ah; codeowners was touched so @sjk07 has to review as well, which is why it's blocked.

Copy link
Member

@sjk07 sjk07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo! Sorry for blocking this.

LGTM!

@dmccaffery dmccaffery merged commit 57ff672 into automotiveMastermind:next Nov 25, 2020
@dmccaffery dmccaffery deleted the build/refactor branch November 25, 2020 17:30
@github-actions
Copy link

🎉 This PR is included in version 8.1.1-next.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch-smart-card: missing keygrip causes script to exit without error
3 participants