Support validate (and import) taking in a schema directly #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most of the zed commands are "zed noun verb", but validation isn't. WDYT about adding a "zed schema validate" and creating a new command for zed "zed file validate/import" for zedfiles. Willing to bikeshed on the names eg "zed yaml validate". |
|
I don't really see a reason to break them into two commands: validate should work on both schema and extended files, especially because once authzed/spicedb#1437 is implemented (or some variant thereof), there will likely be no distinction any longer |
vroldanbet
approved these changes
Jan 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #287