feat: add goreleaser job Slack notifications #2255
Conversation
github-actions
bot
added
the
area/tooling
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
| @@ -48,3 +49,11 @@ jobs: | |||
| GORELEASER_KEY: "${{ secrets.GORELEASER_KEY }}" | |||
| GEMFURY_PUSH_TOKEN: "${{ secrets.GEMFURY_PUSH_TOKEN }}" | |||
| SNAPCRAFT_STORE_CREDENTIALS: "${{ secrets.SNAPCRAFT_STORE_CREDENTIALS }}" | |||
| - name: "Notify Slack of goreleaser status" | |||
| if: "always()" | |||
| uses: "8398a7/action-slack@v3" | |||
There was a problem hiding this comment.
🤔 My first reaction was "Is this a trustworthy GitHub action?".
I found the official Slack GitHub Action, which is verified. Mind sharing why you used action-Slack instead of the official action?
There was a problem hiding this comment.
the 8398a7/action-slack is a very popular action. In the past, I've used it because it allows for detailed customisation that might become handy. A quick search shows that projects such as Laravel, Cilium among others, use it, including this GitHub repo
That said, happy to switch it to the one you linked here. Will update shortly!
There was a problem hiding this comment.
All good, it was more like I wasn't sure I could trust that action, and if there was any specific features one provided the other didn't, I'd typically favour the official action for security reasons.
Verolop
force-pushed
the
builds-notifications
branch
from
367f33e to
965a4a7
Compare
|
closing in favour of #2258 |
this PR adds Slack notifications for the goreleaser job in our release workflow.