Promote reflection APIs from experimental to V1 schema service #2249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api v1
tstirrat15
reviewed
Feb 21, 2025
There was a problem hiding this comment.
This is a copy-paste of the existing code?
There was a problem hiding this comment.
Yep and modified to remove prefixes
internal/services/v1/schema.go
Outdated
| "github.com/authzed/spicedb/pkg/zedtoken" | ||
| ) | ||
|
|
||
| // NewSchemaServer creates a SchemaServiceServer instance. | ||
| func NewSchemaServer(additiveOnly bool, expiringRelsEnabled bool) v1.SchemaServiceServer { | ||
| func NewSchemaServer(additiveOnly bool, iringRelsEnabled bool) v1.SchemaServiceServer { |
The existing experimental code and tests is copied over and adjusted to run with the new message types under the schema service Once released, we'll deprecate the experimental versions and eventually delete the code
josephschorr
force-pushed
the
promote-reflection
branch
from
4bfaf94 to
146f00c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.