Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update security workflow #997

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

diegofigs
Copy link

@diegofigs diegofigs commented Feb 12, 2025

Description

Updates security workflow

Performance / NEAR gas cost considerations

N/A

Testing

N/A

How should this be reviewed

N/A

Additional information

Previous version of workflow was targeted specifically for contracts, newer version is generic and supports different project configurations apart from contracts and has stronger/up-to-date security tooling

@diegofigs diegofigs requested a review from aleksuss as a code owner February 12, 2025 18:25
@diegofigs diegofigs requested a review from mrLSD February 14, 2025 12:43
@mrLSD
Copy link
Member

mrLSD commented Feb 16, 2025

@diegofigs we runs clippy and other engine-related tools in a different way, via cargo make.

jobs:
contract_analysis:
name: "Shared"
uses: aurora-is-near/.github/.github/workflows/contract_analysis.yml@master
uses: aurora-is-near/.github/.github/workflows/security_analysis.yml@master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like black box. And CI fails. It seems better to create engine proposals before such changes, as in engine we run all via cargo make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants