Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styles & history & copy-pasting: refactor #415

Open
5 of 11 tasks
aurelienpierre opened this issue Jan 19, 2025 · 0 comments
Open
5 of 11 tasks

Styles & history & copy-pasting: refactor #415

aurelienpierre opened this issue Jan 19, 2025 · 0 comments
Assignees
@aurelienpierre
Labels
needs refactoring priority: high Affects basic and core functionnalities of the software in a way that severly degrades usability
Milestone
0.1

Comments

@aurelienpierre
Copy link
Collaborator

aurelienpierre commented Jan 19, 2025 •
edited
Loading

That code is unmaintainable, slow, does many redundant operations, and most of it is not thread-safe.

  • don't write history immediately back when reading it 0eb29af
  • cleanup redundant undo/redo commits to stack d1ae32b
  • move xmp writing to a separate thread to prevent filesystem & network I∕O from blocking UI 2d717f8cd5e6ef901c61ab1429048d40176e1f0b
  • auto-save history in background while in darkroom
  • remove GUI code from dt_dev_history_[add/read/pop]_ext()
  • refactor dt_dev_history_[add/read/pop]_ext() to something understandable
  • clean up high-level history copy and paste, add debug strings
  • clean up high-level styles, add debug strings
  • refactor the 3 different methods that write XMP
  • add copy-pasting option to mandatorily create new modules in target pipeline/history
  • add an app-level DB lock on image's history read/write from library
@aurelienpierre aurelienpierre self-assigned this Jan 19, 2025
@aurelienpierre aurelienpierre added priority: high Affects basic and core functionnalities of the software in a way that severly degrades usability needs refactoring labels Jan 19, 2025
@aurelienpierre aurelienpierre added this to the 0.1 milestone Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aurelienpierre aurelienpierre

Labels
needs refactoring priority: high Affects basic and core functionnalities of the software in a way that severly degrades usability
Projects
Ansel development management
Status: In Progress
Milestone
0.1
Development

No branches or pull requests
1 participant
@aurelienpierre