Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pasting development recompute pipe caches in darkroom too #284

Closed
Jiyone opened this issue Dec 18, 2023 · 2 comments
Closed

Make pasting development recompute pipe caches in darkroom too #284

Jiyone opened this issue Dec 18, 2023 · 2 comments
Labels
enhancement priority: critical Affects basic and core functionnalities of the software in a way that prevents it to work at all

Comments

@Jiyone
Copy link
Collaborator

Jiyone commented Dec 18, 2023

Description of the bug

When copy pasting a development to a picture, the pasting is correctly applied but any of the central view, histograms or thubnail are refreshing.

This happens only in darkroom.

To Reproduce

  1. Go to darkroom
  2. Copy a development
  3. Past onto a picture
  4. See nothing have refreshed

Expected behavior

Ansel should recompute the pipe caches

System

  • Ansel version : at least 53c609c
  • OS : Win11 22H2
  • Memory :
  • Graphics card :
  • Graphics driver :
  • OpenCL installed :
  • OpenCL activated :
  • Xorg :
  • Desktop :
  • GTK+ :
  • gcc :
  • cflags :

Additional context

  • Can you reproduce with another darktable version(s)? yes
  • Can you reproduce with a RAW or Jpeg or both? both
  • Are the steps above reproducible with a fresh edit (i.e. after discarding history)? yes
  • Is the issue still present using an empty/new config-dir (e.g. start darktable with --configdir "/tmp")? yes
  • Do you use lua scripts? no
@aurelienpierre
Copy link
Collaborator

Ansel should recompute the pipe caches

It's the thumb cache affected here, the pipe cache affects darkroom only

@Jiyone
Copy link
Collaborator Author

Jiyone commented Dec 18, 2023

the pipe cache affects darkroom only

Not sure what to think about that but, as I said, this happens only in darkroom.

Do you mean that copy/past development is not supposed to recompute the pipe caches yet because it was something available in lighttable only ?
Then this report would be an enhancement.

@Jiyone Jiyone changed the title [Pixelpipe] Pasting development doest trigger recompute in darkroom Make pasting development recompute pipe caches in darkroom too Dec 18, 2023
@Jiyone Jiyone added enhancement priority: critical Affects basic and core functionnalities of the software in a way that prevents it to work at all labels Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement priority: critical Affects basic and core functionnalities of the software in a way that prevents it to work at all
Projects
None yet
Development

No branches or pull requests

2 participants